Add WAL lock to prevent timing lock contention #3927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| panic(fmt.Sprintf("error writing the wal to the index: %s", err.Error())) | ||
| } | ||
| if p.log.EnableLogging { | ||
| p.log.logger.Printf("write to index took of partition %d took %s\n", p.id, time.Since(startTime)) |
|
other than the small nit, +1 |
benbjohnson
force-pushed
the
wal-lock
branch
from
142ef42
to
756d240
Compare
This commit adds a lock to the WAL log to prevent timing how long it takes to obtain the Bolt write lock.
benbjohnson
force-pushed
the
wal-lock
branch
from
756d240
to
d52fe89
Compare
benbjohnson
added a commit
that referenced
this pull request
Sep 1, 2015
Add WAL lock to prevent timing lock contention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request adds a lock to the WAL log to prevent timing how long it takes to obtain the Bolt write lock.