Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSM1 burn - race during shard creation #4442

Closed
otoolep opened this issue Oct 14, 2015 · 3 comments
Closed

TSM1 burn - race during shard creation #4442

otoolep opened this issue Oct 14, 2015 · 3 comments
Assignees
@otoolep
Milestone
0.9.5

Comments

@otoolep
Copy link
Contributor

otoolep commented Oct 14, 2015 

[tsm1wal] 2015/10/13 22:10:07 /var/opt/influxdb/data/stress/default/3 flush to index took 6.022µs
==================
WARNING: DATA RACE
Write by goroutine 112:
  runtime.mapassign1()
      /root/.gvm/gos/go1.5.1/src/runtime/hashmap.go:411 +0x0
  github.com/influxdb/influxdb/tsdb.(*Store).CreateShard()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/tsdb/store.go:116 +0xceb
  github.com/influxdb/influxdb/cluster.(*PointsWriter).writeToShard.func1()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cluster/points_writer.go:278 +0x276

Previous read by goroutine 34:
  github.com/influxdb/influxdb/tsdb.(*Store).ShardIDs()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/tsdb/store.go:171 +0x74
  github.com/influxdb/influxdb/services/retention.(*Service).deleteShards()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/services/retention/service.go:118 +0x446

Goroutine 112 (running) created at:
  github.com/influxdb/influxdb/cluster.(*PointsWriter).writeToShard()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cluster/points_writer.go:306 +0x24a
  github.com/influxdb/influxdb/cluster.(*PointsWriter).WritePoints.func1()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cluster/points_writer.go:232 +0xe1

Goroutine 34 (running) created at:
  github.com/influxdb/influxdb/services/retention.(*Service).Open()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/services/retention/service.go:46 +0x233
  github.com/influxdb/influxdb/cmd/influxd/run.(*Server).Open.func1()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:375 +0x1731
  github.com/influxdb/influxdb/cmd/influxd/run.(*Server).Open()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cmd/influxd/run/server.go:387 +0x3e
  github.com/influxdb/influxdb/cmd/influxd/run.(*Command).Run()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cmd/influxd/run/command.go:121 +0x11e9
  main.(*Main).Run()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cmd/influxd/main.go:86 +0x944
  main.main()
      /tmp/tmp.ClX8v4r8Gt/src/github.com/influxdb/influxdb/cmd/influxd/main.go:46 +0x3ff
==================
@otoolep
Copy link
Contributor Author

otoolep commented Oct 14, 2015

This may not be specifically a tsm1 issue, but was detected during a race-enabled burn test.

@otoolep otoolep self-assigned this Oct 14, 2015
@otoolep otoolep added this to the 0.9.5 milestone Oct 14, 2015
@otoolep
Copy link
Contributor Author

otoolep commented Oct 14, 2015

Yeah, from looking at the trace, almost certainly not a tsm1 issue.

@otoolep otoolep removed the area/tsm label Oct 14, 2015
otoolep added a commit that referenced this issue Oct 14, 2015
@otoolep
RLock access to store's shards
6d38559 
Fix issue #4442.
@otoolep
Copy link
Contributor Author

otoolep commented Oct 14, 2015

Fixed by #4443

@otoolep otoolep mentioned this issue Oct 14, 2015
Merged
@otoolep otoolep closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otoolep otoolep

Labels
None yet
Projects
None yet
Milestone
0.9.5
Development

No branches or pull requests
1 participant
@otoolep