Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.9.5-nightly] trivial bug: USER can parse as USE in the CLI #4544

Closed
beckettsean opened this issue Oct 22, 2015 · 4 comments
Closed

[0.9.5-nightly] trivial bug: USER can parse as USE in the CLI #4544

beckettsean opened this issue Oct 22, 2015 · 4 comments
Labels
difficulty/medium Resolving this issue should take up to a week

Comments

@beckettsean
Copy link
Contributor 

> user _internal
Using database _internal
> use _internal
Using database _internal
>
@beckettsean
Copy link
Contributor Author

I would expect a parser error instead of it "knowing" that I meant use and not user

@otoolep otoolep mentioned this issue Oct 27, 2015
Closed
otoolep added a commit that referenced this issue Oct 27, 2015
@otoolep
More precisely identify commands at CLI
b4a402c 
Since the parsing of commands by the CLI is rather simple, this
also-simple solution ensures that the commands are followed by
whitespace.

Fixes issue #4544.
@otoolep otoolep added difficulty/medium Resolving this issue should take up to a week 0 - Backlog labels Nov 4, 2015
@otoolep
Copy link
Contributor

otoolep commented Nov 4, 2015

The command parsing in the CLI code needs to be a little bit more sophisticated to solve this issue. Ideally the CLI code would parse tokens, allowing more intelligent behaviour.

@otoolep
Copy link
Contributor

otoolep commented Nov 4, 2015

Some initial work is here: https://github.com/influxdb/influxdb/pull/4588/files

But the tests don't pass, so the CLI needs some more work to fix this bug.

@pires
Copy link
Contributor

pires commented Nov 7, 2015

While working on #4628 I had a similar idea, so on it :)

@pires pires mentioned this issue Nov 7, 2015
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/medium Resolving this issue should take up to a week
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@otoolep @pires @beckettsean