Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funky behavior with big (error?) timestamps #6599

Closed
ryantxu opened this issue May 11, 2016 · 2 comments · Fixed by #6675
Closed

Funky behavior with big (error?) timestamps #6599

ryantxu opened this issue May 11, 2016 · 2 comments · Fixed by #6675
Assignees
Milestone

Comments

@ryantxu
Copy link

ryantxu commented May 11, 2016

Directions

I spent a while trying to figure out why data was not visible in the index -- eventually I figured out that I was sending invalid timestamps, but it would be nice to have errors if you send invalid data!

Bug report

System info:
Amazon Linux:
build: "e094138084855d444195b252314dfee9eae34cab" "0.12.1"
"go1.4.3"

Steps to reproduce:

  1. Index with invalid timestamp
    m1 a=1.2 9223372036854775807
  2. Show Fields... gives you nothing!
    SHOW FIELD KEYS
  3. Index a valid value
    m2 a=1.2
  4. Show Fields... now shows values for both m1 and m2
    SHOW FIELD KEYS
  5. Select data from m1 & m2
    SELECT * FROM m1
    SELECT * FROM m2
    nothing form m1, 1 result for m2

Expected behavior:

If I send request and get a 2XX response, i assume it is indexed. If I send a bad request i want a 4XX or 5XX response

Actual behavior:

see above

@e-dard e-dard self-assigned this May 18, 2016
@e-dard e-dard added this to the 1.0.0 milestone May 18, 2016
@e-dard
Copy link
Contributor

e-dard commented May 19, 2016

@ryantxu I just wanted clarify a couple of things here.

Firstly, yes you have uncovered a bug, in fact I think there may be two bugs here!

The timestamp value 9223372036854775807 is actually valid (in fact it's the largest timestamp value InfluxDB accepts).

I'm going to figure out why the point is not being stored.

e-dard added a commit that referenced this issue May 20, 2016
If all points in a series are timestamped in the future, the SHOW
queries will not return anything from these series.

This commit changes the to time used when querying shards for the SHOW
queries to the maximum time, in order to ensure future points are
considered in the results for these queries.

Fixes #6599.
@jsternberg
Copy link
Contributor

I pushed another fix related to this issue at #6693.

The shard groups when you had a shard group near the time boundary wasn't being created correctly and would result in the data point being inaccessible on a restart. Unfortunately, there's no way to fix the shard after it's been created natively. If you write any points into a shard at the time boundary, I think you're going to have to drop that shard and insert the data again.

e-dard added a commit that referenced this issue May 26, 2016
If all points in a series are timestamped in the future, the SHOW
queries will not return anything from these series.

This commit changes the to time used when querying shards for the SHOW
queries to the maximum time, in order to ensure future points are
considered in the results for these queries.

Fixes #6599.
@timhallinflux timhallinflux modified the milestones: 1.0.0, 1.0.0 beta Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants