Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update defaults in config for latest best practices #7320

Closed
beckettsean opened this issue Sep 16, 2016 · 2 comments
Closed

update defaults in config for latest best practices #7320

beckettsean opened this issue Sep 16, 2016 · 2 comments

Comments

@beckettsean
Copy link
Contributor

beckettsean commented Sep 16, 2016

remove compact-min-file-count and max-points-per-block
reduce compact-full-write-cold-duration and cache-snapshot-write-cold-duration settings
increase cache-max-memory-size?

@kostasb
Copy link

kostasb commented Sep 26, 2016

These changes will affect many users since most use default values.

Some suggestions:

cache-max-memory-size = 1048576000
Users with hot shards growing fast have had to increase this value. It should cause no harm raising it as it is only the maximum and can help avoid errors when hitting the max.

cache-snapshot-memory-size = 104857600
This is the in memory representation of cache, which can be different from the size on disk. Flushing the cache in larger chunks may yield better performance. There are indications from a few real world cases that this can help reduce I/O, but no hard numbers.

cache-snapshot-write-cold-duration = 10m
time allowed before cold cache gets flushed

compact-full-write-cold-duration = 4h
time allowed before a cold shard is compacted

Would be great to have performance testing figures with the old defaults and the new ones before decisions are made.

@jwilder jwilder self-assigned this Oct 20, 2016
@e-dard
Copy link
Contributor

e-dard commented Oct 24, 2016

@jwilder could you add a note about how the demo config file works in terms of describing the current default values in comments? That will clear this issue up then #7504

jwilder added a commit that referenced this issue Oct 24, 2016
This updates the config file to:
* Have all config options that do not change the default to be commented
out
* Removes old config options that are no longer available
* Updates config options to new defaults based on prior bugs and tuning
recommendations

Fixes #7320
Fixes #7504
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants