Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tasks page adminui #11700

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Feat/tasks page adminui #11700

merged 1 commit into from
Feb 6, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 5, 2019

Making TasksPage component more generic so it is shared with Organization page as well. Created a tasks container component which gets tasks and sends them as props in tasks page

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

screen shot 2019-02-05 at 3 25 58 pm

@Palakp41 Palakp41 force-pushed the feat/tasks-page-adminui branch 3 times, most recently from cbe0706 to da9ded2 Compare February 6, 2019 19:44
Copy link
Contributor

@bthesorceror bthesorceror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion but 👍

@Palakp41 Palakp41 merged commit 3636784 into master Feb 6, 2019
@Palakp41 Palakp41 deleted the feat/tasks-page-adminui branch February 6, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants