feat(ui): Add the ability to name a scraper target #11809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
feat/naming-scrapers
branch
from
e0ab676
to
f390bb6
Compare
chnn
approved these changes
Feb 12, 2019
| @@ -31,8 +31,6 @@ class ConfigureDataSourceSwitcher extends PureComponent<Props> { | |||
| <Scraping onClickNext={onClickNext} buckets={buckets} /> | |||
| </div> | |||
| ) | |||
| case DataLoaderType.CSV: | |||
There was a problem hiding this comment.
i cant believe that was in there for so long. oops
ischolten
force-pushed
the
feat/naming-scrapers
branch
from
f390bb6
to
e04e721
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11784
Briefly describe your proposed changes:
Provides input for the scraper target to be named in scraper configuration
Update the client library dependency so get the correct Scraper type.