Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine permisssions in the ui on token overlay #11879

Merged
merged 1 commit into from Feb 14, 2019
Merged

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 13, 2019

Closes #11780

Briefly describe your proposed changes:
Updated token overlay to create an object with unique keys and values array for multiple actions

  • Rebased/mergeable
  • Tests pass

screen shot 2019-02-13 at 2 08 49 pm

Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some purely stylistic alternatives but 👍 👍

ui/src/me/components/account/ViewTokenOverlay.tsx Outdated Show resolved Hide resolved
ui/src/me/components/account/ViewTokenOverlay.tsx Outdated Show resolved Hide resolved
ui/src/me/components/account/ViewTokenOverlay.tsx Outdated Show resolved Hide resolved
@Palakp41 Palakp41 merged commit 9716ad7 into master Feb 14, 2019
@Palakp41 Palakp41 deleted the fix/permissions-ui branch February 14, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants