Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update retention policy for bucket if time changes #11997

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

Palakp41
Copy link
Contributor

@Palakp41 Palakp41 commented Feb 20, 2019

Closes #11915

Briefly describe your proposed changes:
Updated handler for retention policy to update the type of retention policy and the state of bucket to take in default seconds

  • Rebased/mergeable
  • Tests pass

@Palakp41 Palakp41 force-pushed the fix/bucket-update-retention-policy branch from 57a4f00 to 46cd249 Compare February 20, 2019 01:21
Copy link
Contributor

@OfTheDelmer OfTheDelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

ui/src/organizations/components/Retention.tsx Outdated Show resolved Hide resolved
ui/src/organizations/components/UpdateBucketOverlay.tsx Outdated Show resolved Hide resolved
ui/src/organizations/components/UpdateBucketOverlay.tsx Outdated Show resolved Hide resolved
@Palakp41 Palakp41 force-pushed the fix/bucket-update-retention-policy branch from 46cd249 to 464cfdc Compare February 20, 2019 18:15
@Palakp41 Palakp41 force-pushed the fix/bucket-update-retention-policy branch from 464cfdc to 55bf3d1 Compare February 20, 2019 18:16
@Palakp41 Palakp41 merged commit ab98c8c into master Feb 20, 2019
@Palakp41 Palakp41 deleted the fix/bucket-update-retention-policy branch February 20, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants