Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish/code snippets #12302

Merged
merged 4 commits into from
Mar 1, 2019
Merged

Polish/code snippets #12302

merged 4 commits into from
Mar 1, 2019

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Mar 1, 2019 •
edited

Closes #12150
Closes #12256

screen shot 2019-03-01 at 12 05 38 pm

Rename CopyText to CodeSnippet
Import stylesheet into component instead of chronograf.scss
Make "Copy" button visible all the time
Add a minimum height to code snippet so it renders properly in Firefox

  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@alexpaxton
Copy link
Contributor Author

There is still clipping but it is the result of something in @influxdata/react-custom-scrollbars

OfTheDelmer
OfTheDelmer approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@OfTheDelmer OfTheDelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@alexpaxton alexpaxton merged commit 86f5753 into master Mar 1, 2019
@alexpaxton alexpaxton deleted the polish/code-snippets branch March 1, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfTheDelmer OfTheDelmer OfTheDelmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexpaxton @OfTheDelmer