Polish Label Color Picker #12464
Merged
Polish Label Color Picker #12464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
approved these changes
Mar 8, 2019
| } | ||
|
|
||
| export default class ColorPicker extends Component<Props, State> { | ||
| public static defaultProps: DefaultProps = { |
| const properties = {...this.state.label.properties, color} | ||
| const label = {...this.state.label, properties} | ||
|
|
||
| this.setState({label}) | ||
| } | ||
| console.log(hexcodeStatus) |
| private handleSelectColor = (color: string): void => { | ||
| this.setState({color}) | ||
| } | ||
|
|
||
| private handleChangeInput = (_: ChangeEvent<HTMLInputElement>): void => { | ||
| // console.log('changing: ', e) |
There was a problem hiding this comment.
could this console.log commetn be removed?
There was a problem hiding this comment.
I think this is actually in there on master. It makes me wonder if the settings page is even doing anything
| } | ||
| } | ||
|
|
||
| componentDidUpdate(prevProps) { |
There was a problem hiding this comment.
should prevProps be typed?
|
|
||
| componentDidUpdate(prevProps) { | ||
| if (prevProps.selectedHex !== this.props.selectedHex) { | ||
| this.setState({inputValue: this.props.selectedHex}) |
There was a problem hiding this comment.
is it necessary to keep track of the hex value in state? it seems like this will be creating two sources of truth? could all the places that state instead call the onSelect() prop?
|
@ischolten I refactored this thing a bit so it's a controlled component. I only store hexcode validation in the color picker state so that doesn't need to be repeated everywhere this component is used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10810
ColorPickercomponentColorPickercomponentChecklist