Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/add note dashboard #12703

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Refactor/add note dashboard #12703

merged 1 commit into from
Mar 18, 2019

Conversation

bthesorceror
Copy link
Contributor

@bthesorceror bthesorceror commented Mar 18, 2019 •
edited

Closes #12632

  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

chnn
chnn approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@chnn chnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great.

ui/src/dashboards/actions/notes.ts
const {
views: {views},
} = getState()
const currentViewState = views[id]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a selector for this if you are so inclined

@bthesorceror @ischolten
Move add note overlay to react router
4fc97b1 
Co-authored-by: Iris Scholten <ischolten.is@gmail.com>
@ischolten ischolten merged commit a6abcea into master Mar 18, 2019
@ischolten ischolten deleted the refactor/add-note-dashboard branch March 18, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chnn chnn chnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bthesorceror @chnn @ischolten