Polish Create From Template Overlay #13424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use custom UI instead of responsive grid
ebb-tide
reviewed
Apr 16, 2019
| const {createDashboardFromTemplate} = this.props | ||
|
|
||
| await createDashboardFromTemplate(this.state | ||
| .selectedTemplate as DashboardTemplate) |
There was a problem hiding this comment.
This would be much easier to read if they were two steps like:
dashboardTemplate = this.state.selectedTemplate as DashboardTemplate
await createDashboardFromTemplate(dashboardTemplate)
| onSelectTemplate: (selectedTemplateSummary: TemplateSummary) => void | ||
| } | ||
|
|
||
| class DashboardTemplateBrowser extends PureComponent<Props> { |
There was a problem hiding this comment.
This could be an SFC?? :)
| Columns, | ||
| DapperScrollbars, | ||
| } from '@influxdata/clockface' | ||
| import {TemplateSummary, ITemplate} from '@influxdata/influx' |
There was a problem hiding this comment.
I think we should prefer to import from src/types instead of directly from client since sometimes types are altered in the process.
| let templateName = name || 'Untitled' | ||
|
|
||
| if (version) { | ||
| templateName = `${name || 'Untitled'} (v${version})` |
There was a problem hiding this comment.
hrmm. we are not currently using version in a way that makes it make sense to expose it so saliently to the user. I'm actually a little unsure how we should use versions. Maybe let's not display this to user. ?
There was a problem hiding this comment.
Sure! I figure it will be more useful in the future
ebb-tide
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13203
Closes #13343
DashboardCreateFromTemplateOverlayCreatebutton if no template is selectedNotes
I think we could extract out some of these components into a generic set of
Create ___ from Templatecomponents + styles.Checklist