Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate Limiting notifications on read/write endpoints #13561

Merged
merged 1 commit into from Apr 22, 2019
Merged

Rate Limiting notifications on read/write endpoints #13561

merged 1 commit into from Apr 22, 2019

Conversation

ebb-tide
Copy link
Contributor

@ebb-tide ebb-tide commented Apr 22, 2019 •
edited by lukevmorris

Closes #13422

@ebb-tide ebb-tide changed the title Feat rate limiting Rate Limiting notifications on read/write endpoints Apr 22, 2019
lukevmorris
lukevmorris approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@lukevmorris lukevmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me!

ui/src/shared/copy/notifications.ts Show resolved Hide resolved
ui/src/dataLoaders/actions/dataLoaders.ts Outdated Show resolved Hide resolved
bthesorceror
bthesorceror approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@bthesorceror bthesorceror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

ischolten
ischolten approved these changes Apr 22, 2019
View reviewed changes
Copy link
Contributor

@ischolten ischolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ui/src/limits/actions/index.ts Outdated Show resolved Hide resolved
ui/src/shared/copy/notifications.ts Show resolved Hide resolved
ui/src/shared/copy/notifications.ts Show resolved Hide resolved
@ebb-tide
Fix typon in create dashboard notification
4704786 
Notify on 429 errors on query in dashboard and DE
Notify on 429 error in line protocol write
Query for limitStatus on Dashboard and DE load
Remove React import in LimitChecker
Rename limits folder to cloud
Add strict comparison to status code checking
Prevent blow up if error doesn't contain status
convert readLimit writeLimit to boolean sounding vars
@ebb-tide ebb-tide merged commit 432c462 into master Apr 22, 2019
@ebb-tide ebb-tide deleted the feat-rate-limiting branch April 22, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukevmorris lukevmorris lukevmorris approved these changes

@bthesorceror bthesorceror bthesorceror approved these changes

@ischolten ischolten ischolten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The UI should display easy to understand notifications on rate/limiting errors for queries
4 participants
@ebb-tide @bthesorceror @lukevmorris @ischolten