Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DapperScrollbars in inline label editor #13584

Merged
merged 5 commits into from
Apr 23, 2019
Merged

Conversation

alexpaxton
Copy link
Contributor

Closes #12987

Use DapperScrollbars component instead of FancyScrollbars
Discovered an issue along the way: #13583

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@@ -33,9 +32,14 @@ class InlineLabelsList extends Component<Props> {
public render() {
return (
<div className="inline-labels--list-container">
<FancyScrollbar autoHide={false} autoHeight={true} maxHeight={250}>
<DapperScrollbars
autoSize={true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t this already the default value?

@alexpaxton alexpaxton merged commit 191c16c into master Apr 23, 2019
@alexpaxton alexpaxton deleted the fix/inline-label-firefox branch April 23, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Label creation CSS issues on firefox
3 participants