Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DapperScrollbars in inline label editor #13584

Merged
merged 5 commits into from Apr 23, 2019

Conversation

@alexpaxton
Copy link
Member

alexpaxton commented Apr 23, 2019

Closes #12987

Use DapperScrollbars component instead of FancyScrollbars
Discovered an issue along the way: #13583

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)
Palakp41 and others added 4 commits Apr 22, 2019
wip
@@ -33,9 +32,14 @@ class InlineLabelsList extends Component<Props> {
public render() {
return (
<div className="inline-labels--list-container">
<FancyScrollbar autoHide={false} autoHeight={true} maxHeight={250}>
<DapperScrollbars
autoSize={true}

This comment has been minimized.

Copy link
@mavarius

mavarius Apr 23, 2019

Contributor

Isn’t this already the default value?

@alexpaxton alexpaxton merged commit 191c16c into master Apr 23, 2019
7 checks passed
7 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: e2e Your tests passed on CircleCI!
Details
ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: jstest Your tests passed on CircleCI!
Details
ci/circleci: litmus_daily Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
@alexpaxton alexpaxton deleted the fix/inline-label-firefox branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.