feat(ui): Add option to generate read / write token #13601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
feat/buckets-token
branch
from
de20bf4
to
2574774
Compare
ebb-tide
approved these changes
Apr 24, 2019
| </Form.Element> | ||
| <Form.Element label=""> | ||
| <GetResources resource={ResourceTypes.Buckets}> | ||
| <SpinnerContainer |
There was a problem hiding this comment.
I think GetResources should handle loading state for you?
There was a problem hiding this comment.
ah youre so right!
|
|
||
| private handleSelectBucket( | ||
| bucketName: string, | ||
| bucketNames: string[] |
There was a problem hiding this comment.
nit: maybe this var could be called selectedBuckets? Might this function be better as a util?
There was a problem hiding this comment.
yea ill rename and make util
| } | ||
| } | ||
|
|
||
| export default SelectableBucket |
There was a problem hiding this comment.
maybe.. delectableBucket?
| @@ -38,7 +39,7 @@ class TokenRow extends PureComponent<Props> { | |||
| <EditableName | |||
| onUpdate={this.handleUpdateName} | |||
| name={description} | |||
| noNameString="DEFAULT_BUCKET_NAME" | |||
| noNameString={DEFAULT_TOKEN_NAME} | |||
ui/src/dashboards/constants/index.ts
Outdated
| @@ -90,6 +90,7 @@ type NewDefaultDashboard = Pick< | |||
| export const DEFAULT_CELL_NAME = 'Name this Cell' | |||
| export const DEFAULT_DASHBOARD_NAME = 'Name this Dashboard' | |||
| export const DEFAULT_BUCKET_NAME = 'Name this Bucket' | |||
| export const DEFAULT_TOKEN_NAME = 'Describe this Token' | |||
There was a problem hiding this comment.
why describe here instead of Name this token?
There was a problem hiding this comment.
Tokens dont have names, just descriptions. the variable should be renamed to reflect that
ebb-tide
force-pushed
the
feat/buckets-token
branch
from
2574774
to
d0f1891
Compare
ischolten
force-pushed
the
feat/buckets-token
branch
2 times, most recently
from
e3acbf0
to
d99a1e1
Compare
ischolten
force-pushed
the
feat/buckets-token
branch
from
d99a1e1
to
62f2d63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12848
Briefly describe your proposed changes: