Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): ensure map type variables can get selected key #13783

Merged
merged 1 commit into from May 6, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented May 3, 2019

Closes #13749

Describe your proposed changes here.

@@ -58,7 +58,7 @@ export const getVariableValuesForDropdown = (
const selection = list.find(({value}) => value === selectedValue)

return {
selectedKey: selection[0],
selectedKey: selection.name,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooops!

Copy link
Contributor

@OfTheDelmer OfTheDelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major feedback, looks good overall

}
}

describe('Dashboards.Components.VariablesControlBar.VariableDropdown', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay more tests

ui/src/dashboards/selectors/index.ts Outdated Show resolved Hide resolved
@ischolten ischolten merged commit 4b7c10a into master May 6, 2019
@ischolten ischolten deleted the fix/map-var branch May 6, 2019 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map variable type doesn't work
3 participants