Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Export and download resource with formatted resource name #13925

Merged
merged 1 commit into from May 15, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented May 14, 2019

Closes #13781

When a resource is downloaded or exported, it should use the name of the resource. remove spaces and lowercase.

import {formatDownloadName} from './download'

describe('formatDownloadName', () => [
it('formats name correctly', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 nice!

@ischolten ischolten merged commit 8e76d8f into master May 15, 2019
@ischolten ischolten deleted the fix/download-names branch May 15, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize file downloads from the ui
2 participants