Add heatmap vis type #13945
Merged
Add heatmap vis type #13945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
approved these changes
May 17, 2019
|
|
||
| const colors = | ||
| storedColors && storedColors.length | ||
| ? storedColors |
There was a problem hiding this comment.
ah, some colors are string[] and some are the color interface- would you mind adding a type assertion that trickles to this to protect against someone reverting to color type? or maybe just add it to the tech debt to-do list for now? :)
alexpaxton
reviewed
May 17, 2019
| display: flex; | ||
| justify-content: flex-start; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .color-scheme-dropdown--swatches { | ||
| .color-scheme-dropdown-item--swatches { |
alexpaxton
approved these changes
May 17, 2019
| colors: string[] | ||
| } | ||
|
|
||
| const ColorSchemeDropdownItem: FunctionComponent<Props> = ({name, colors}) => { |
There was a problem hiding this comment.
Good to see more function components
| @@ -120,7 +124,7 @@ const XYContainer: FunctionComponent<Props> = ({ | |||
| } | |||
|
|
|||
| return ( | |||
| <div className="xy-container"> | |||
| <div className="vis-plot-container"> | |||
There was a problem hiding this comment.
It's all in the details
chnn
force-pushed
the
add-heatmap
branch
2 times, most recently
from
4d0482b
to
d673349
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13871
Adds a heatmap / 2D histogram visualization type:
The ability to create heatmaps is feature flagged in the UI, which will help us roll out the API updates to cloud before the UI updates.
To enable the feature, open the dev tools and type:
Then refresh the page.
The heatmaps will recompute the binning statistic on zoom and resize:
Heatmaps support a variety of visualization options:
The line and histogram options have been tweaked for consistency between all visualization types, though there's still lots of work to do in cleaning up the vis options: