Enable formatting line graph y ticks with binary prefix #14059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chnn
force-pushed
the
add-y-prefix-formatting
branch
2 times, most recently
from
f596d42
to
1e69776
Compare
alexpaxton
approved these changes
Jun 4, 2019
| </Radio.Button> | ||
| <Radio.Button | ||
| id="y-values-format-tab--kmb" | ||
| value={BASE_10} | ||
| active={base === BASE_10} | ||
| titleText="Thousand / Million / Billion" | ||
| titleText="Format values using a SI unit prefix" |
There was a problem hiding this comment.
What do you think of spelling out the full name of SI in the titleText?
There was a problem hiding this comment.
Good point! I updated it.
chnn
force-pushed
the
add-y-prefix-formatting
branch
from
1e69776
to
cb131f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14051
When formatting ticks with a binary unit prefix, the generated tick intervals aren't super nice. I've created influxdata/giraffe#79 and influxdata/giraffe#80 to track this issue.