Gauge polish #14194
Merged
Gauge polish #14194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
approved these changes
Jun 25, 2019
| const {width, height} = this.props | ||
| const dpRatio = window.devicePixelRatio || 1 | ||
|
|
||
| // Set up canvas to draw on HiDPI / Retina screens correctly |
| @@ -282,15 +282,14 @@ class Gauge extends Component<Props> { | |||
| const {prefix, suffix, decimalPlaces} = this.props | |||
| const {degree, lineCount, labelColor, labelFontSize} = GAUGE_SPECS | |||
|
|
|||
| const incrementValue = (maxValue - minValue) / lineCount | |||
| const tickValues = [ | |||
| ..._.range(minValue, maxValue, Math.abs(maxValue - minValue) / lineCount), | |||
|
|
||
| const labels = [] | ||
| for (let g = minValue; g < maxValue; g += incrementValue) { |
| const needleRotation = (gaugePosition - minValue) / (maxValue - minValue) | ||
| let needleRotation: number | ||
|
|
||
| if (gaugePosition <= minValue) { |
There was a problem hiding this comment.
This is awesome! how do you feel about a function like getNeedleRotation and sticking that logic there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I investigated #14175 + https://github.com/influxdata/EAR/issues/823 and discovered the root issue is that the threshold settings component emits nonsensical settings. I opened up #14190 to track resolution.
In the meantime I made some minor gauge tweaks. It now displays better on HiDPI / Retina screens.
Before (you will need a HiDPI screen to see the blurriness):
After:
I also tweaked how the gauge behaves when the needle position is beyond the domain of the gauge (for example if the current value is 6,000,000 and the max value for the gauge is 100). Before the needle would display at an essentially random position ¯_(ツ)_/¯ (some sort of modular arithmetic).
Now it will be clamped to just beyond the domain: