Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(kit/errors): remove the unused errors function #14215

Closed
wants to merge 1 commit into from

Conversation

jsternberg
Copy link
Contributor

It seems that kit/errors was originally created as an experiment for
the error handling that is in the root package. The New method seems
to have been exclusively used by portions of the code that likely got
the wrong or unintended implementation by using goimports rather than
intentionally.

The proper influxdb error handling mechanism is in the root package and
not the struct that was in kit/errors so this removes that code and
points the sections of the code that accidentally used that part of the
package to the more appropriate packages for their use cases.

The package will still be around though because it contains a useful way
to aggregate and list multiple errors which is used by one section of
the code.

It seems that `kit/errors` was originally created as an experiment for
the error handling that is in the root package. The `New` method seems
to have been exclusively used by portions of the code that likely got
the wrong or unintended implementation by using `goimports` rather than
intentionally.

The proper influxdb error handling mechanism is in the root package and
not the struct that was in `kit/errors` so this removes that code and
points the sections of the code that accidentally used that part of the
package to the more appropriate packages for their use cases.

The package will still be around though because it contains a useful way
to aggregate and list multiple errors which is used by one section of
the code.
@stale
Copy link

stale bot commented Sep 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 25, 2019
@stale
Copy link

stale bot commented Oct 2, 2019

This issue has been automatically closed because it has not had recent activity. Please reopen if this issue is still important to you. Thank you for your contributions.

@stale stale bot closed this Oct 2, 2019
@jacobmarble jacobmarble deleted the refactor/remove-unused-errors-function branch January 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant