Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tasks): remove old auth code and allow only token auth #14353

Merged
merged 2 commits into from Jul 26, 2019
Merged

chore(tasks): remove old auth code and allow only token auth #14353

merged 2 commits into from Jul 26, 2019

Conversation

AlirieGray
Copy link
Contributor

@AlirieGray AlirieGray commented Jul 16, 2019 •
edited

Closes #12409
Closes #14353

This PR makes it so that a token must be provided in order to create a task.

@AlirieGray AlirieGray requested a review from a team as a code owner July 16, 2019 18:00
kelwang
kelwang approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@kelwang kelwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@AlirieGray AlirieGray force-pushed the task/require-token-for-creation branch 2 times, most recently from 0fe9d10 to 3b7face Compare July 16, 2019 18:06
@AlirieGray
Copy link
Contributor Author

AlirieGray commented Jul 16, 2019 •
edited

not ready to merge
blocked on UI team adding ability to create tasks with a token on the frontend

@AlirieGray AlirieGray force-pushed the task/require-token-for-creation branch from 3b7face to 0c3d78b Compare July 16, 2019 19:17
@AlirieGray AlirieGray mentioned this pull request Jul 16, 2019
Closed
@AlirieGray AlirieGray force-pushed the task/require-token-for-creation branch 4 times, most recently from 13fbc03 to 7b69f75 Compare July 23, 2019 20:41
@AlirieGray AlirieGray force-pushed the task/require-token-for-creation branch from 7b69f75 to 475e945 Compare July 25, 2019 20:29
@AlirieGray AlirieGray force-pushed the task/require-token-for-creation branch from 475e945 to 7b96bd9 Compare July 26, 2019 16:51
@AlirieGray AlirieGray merged commit 0161438 into master Jul 26, 2019
@AlirieGray AlirieGray deleted the task/require-token-for-creation branch July 26, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task: require explicit authorization when creating task
2 participants
@AlirieGray @kelwang