fix(ui): avoid single stat crash #14423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `latestValues` logic to ignore null/empty Flux rows. This prevents a single stat/gauge crash. Also wraps the time machine `Vis` in a error boundary, to mitigate the results of a crash. Closes #14422
ghost
requested review from
ebb-tide
approved these changes
Jul 23, 2019
| const table = fromFlux(resp).table | ||
| const result = latestValues(table) | ||
|
|
||
| expect(result).toEqual([4, 6.0, 2.0, 8.0]) | ||
| }) | ||
|
|
||
| test('ignores rows with empty values', () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
latestValueslogic to ignore null/empty Flux rows. This prevents a single stat/gauge crash.Also wraps the time machine
Visin a error boundary, to mitigate the results of a crash.Closes #14422