Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enforce bucket authentication on task update #14480

Merged
merged 1 commit into from Jul 26, 2019
Merged

fix: enforce bucket authentication on task update #14480

merged 1 commit into from Jul 26, 2019

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Jul 26, 2019 •
edited

Prior to this change the UpdateTask action would authorize the original task and not the updated task.

This change ensures that the update being applied to a task is authorized.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac changed the title Check Updated Tasks Auth fix: enforce bucket authentication on task update Jul 26, 2019
@GeorgeMac GeorgeMac requested a review from lyondhill July 26, 2019 14:00
lyondhill
lyondhill approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@lyondhill lyondhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GeorgeMac GeorgeMac merged commit a481d4a into master Jul 26, 2019
@GeorgeMac GeorgeMac deleted the gm/task-auth branch July 26, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyondhill lyondhill lyondhill approved these changes

Assignees
No one assigned
Labels
area/auth area/tasks team/compute
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeorgeMac @lyondhill @stuartcarnie