Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add new jsonweb package #15151

Merged
merged 1 commit into from Sep 19, 2019
Merged

feat(auth): add new jsonweb package #15151

merged 1 commit into from Sep 19, 2019

Conversation

GeorgeMac
Copy link
Contributor

@GeorgeMac GeorgeMac commented Sep 16, 2019

Closes #14971

This introduces the jsonweb package which contains types for parsing JWTs into a type suitable for use as an influxdb.Authorizer. This opens up the ability to start work on jwt based authentication in the API.

The original issue imagined an authorizer type. However, this has evolved into the form of a token type which happens to implement Authorizer interface. The next piece of work will be to integrate this into https://github.com/influxdata/influxdb/blob/master/http/authentication_middleware.go#L104

Update: I have a draft PR of the next piece of work which based on this one here #15151

These could also be merged if that is more preferrable.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@GeorgeMac GeorgeMac force-pushed the gm/jsonweb branch 2 times, most recently from bfc836c to 6297532 Compare September 16, 2019 11:57
@GeorgeMac GeorgeMac marked this pull request as ready for review September 16, 2019 13:19
@GeorgeMac GeorgeMac changed the title Add jwt based Authorizer feat(auth): add new jsonweb package Sep 19, 2019
@GeorgeMac GeorgeMac merged commit ddce5d3 into master Sep 19, 2019
@GeorgeMac GeorgeMac deleted the gm/jsonweb branch September 19, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JWT backed implementation of influxdb.Authorizer
2 participants