Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(templates): add jmeter template #15168

Merged
merged 10 commits into from Sep 26, 2019
Merged

fix(templates): add jmeter template #15168

merged 10 commits into from Sep 26, 2019

Conversation

russorat
Copy link
Contributor

@russorat russorat commented Sep 16, 2019 •
edited

don't merge until influxdata/influxdb-templates#24 is closed and a new version of the templates package is cut.

Closes #

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@desa
Copy link
Contributor

desa commented Sep 26, 2019

@russorat I think you need to run yarn to update the lock file

@russorat russorat requested review from a team as code owners September 26, 2019 18:06
@russorat russorat merged commit 73ac9c5 into master Sep 26, 2019
@russorat russorat deleted the fix/add-jmeter-template branch September 26, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desa desa desa approved these changes

@ebb-tide ebb-tide ebb-tide approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russorat @desa @ebb-tide