feat(tasks): expose lastRunStatus and lastRunError in task API #15650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavincabbage
force-pushed
the
feat/last-run-status
branch
3 times, most recently
from
bf79bb1
to
aeb61fb
Compare
ghost
requested review from
gavincabbage
requested review from
stuartcarnie
and removed request for
gianarb
ebb-tide
reviewed
Oct 30, 2019
| @@ -7155,6 +7155,16 @@ components: | |||
| type: string | |||
| format: date-time | |||
| readOnly: true | |||
| lastRunStatus: | |||
gavincabbage
force-pushed
the
feat/last-run-status
branch
from
aeb61fb
to
75147d0
Compare
stuartcarnie
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15153
This PR exposes
lastRunStatusandlastRunErrorin the task API object and records corresponding fields on the backend task model. IflastRunStatusis"failed",lastRunErroris recorded as the last message in the task run log. Otherwise,lastRunErroris cleared. Both new fields are excluded from the response if empty.The task update logic is augmented to allow the status and error to be updated, and the task run finish logic takes advantage of this new capability. Tests are included.