refactor(ui): update home page animations #15809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
drdelambre and
hoorayimhelping
and removed request for
a team
drdelambre
approved these changes
Nov 8, 2019
| </div> | ||
| ) | ||
| const GettingStarted: FunctionComponent<WithRouterProps> = ({ | ||
| params: {orgID}, |
There was a problem hiding this comment.
it would be super cool if this came from the org store and not the router. feels weird, because we are including the router anyways, but by having redux be the single source of truth and only using the router as an event marker / generator, it makes the code easier to manage overall
There was a problem hiding this comment.
That's a good call, I'll update this guy. We gon' catch all them loose threads
| @@ -3,34 +3,31 @@ | |||
| ------------------------------------------------------------------------------ | |||
| */ | |||
|
|
|||
| $collector-graphic-anim-time: 0.5s; | |||
| $collector-graphic-anim-time: 0.1s; | |||
hoorayimhelping
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paneland CSS Grid1.0.5to utilize button mouse interactions