Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Show empty dashboards state #15853

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Nov 12, 2019

Closes #15656

When dashboards length is 0, props.children evaluates to null rather than false, so that clockface will render the default state.

image

@TCL735 TCL735 requested a review from a team November 12, 2019 00:11
@ghost ghost requested review from ebb-tide and zoesteinkamp and removed request for a team November 12, 2019 00:11
@alexpaxton
Copy link
Contributor

@TCL735 can you add a screenshot in the description?

Copy link
Contributor

@alexpaxton alexpaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Groovy, nice work

@drdelambre drdelambre merged commit de53875 into master Nov 12, 2019
@drdelambre drdelambre deleted the fix_15656_dashboard_default branch November 12, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards index has no empty state
3 participants