Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): update wording and remove name editing in checks page #15884

Merged
merged 1 commit into from
Nov 13, 2019
Merged

fix(ui): update wording and remove name editing in checks page #15884

merged 1 commit into from
Nov 13, 2019

Conversation

TCL735
Copy link
Contributor

@TCL735 TCL735 commented Nov 13, 2019 •
edited
Loading

Closes #15108

Changes:

  1. Define Query
  2. Configure Check

Name editing removed in the card (bottom left).

Looks like this:
image

@TCL735 TCL735 force-pushed the fix_15108_update_create_check branch from 99b44ed to a888b6c Compare November 13, 2019 01:43
@TCL735 TCL735 force-pushed the fix_15108_update_create_check branch from a888b6c to 23243ba Compare November 13, 2019 01:50
desa
desa approved these changes Nov 13, 2019
View reviewed changes
Copy link
Contributor

@desa desa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TCL735 TCL735 merged commit 111f9f2 into master Nov 13, 2019
@TCL735 TCL735 deleted the fix_15108_update_create_check branch November 13, 2019 16:54
@kelseiv kelseiv mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desa desa desa approved these changes

@alexpaxton alexpaxton Awaiting requested review from alexpaxton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update title of create a check page
2 participants
@TCL735 @desa