Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): arrows in table #15920

Merged
merged 2 commits into from
Nov 15, 2019
Merged

fix(ui): arrows in table #15920

merged 2 commits into from
Nov 15, 2019

Conversation

zoesteinkamp
Copy link
Contributor

The fix for getting sorting to work

Closes #15888

Describe your proposed changes here.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@zoesteinkamp
fix(ui): arrows in table
96d2732 
The fix for getting sorting to work
@zoesteinkamp zoesteinkamp requested a review from a team November 14, 2019 21:56
@ghost ghost requested review from hoorayimhelping and TCL735 and removed request for a team November 14, 2019 21:56
@zoesteinkamp
fix(ui): arrows in table
ae54fd3 
Change to function
@zoesteinkamp zoesteinkamp merged commit eb5e0e4 into master Nov 15, 2019
@mark-rushakoff mark-rushakoff deleted the zs-arrowsintable-#15888 branch April 16, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drdelambre drdelambre drdelambre left review comments

@TCL735 TCL735 TCL735 approved these changes

@hoorayimhelping hoorayimhelping Awaiting requested review from hoorayimhelping

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrows in table UI don't do anything
3 participants
@zoesteinkamp @drdelambre @TCL735