feat: add support for setting password and org for a new user in the cli #15981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
15897/pkger_authentication
branch
from
c6448ac
to
15f3dd0
Compare
jsteenb2
force-pushed
the
15897/pkger_authentication
branch
5 times, most recently
from
80dd3e5
to
c8e504c
Compare
jsteenb2
commented
Nov 19, 2019
| @@ -17,21 +17,27 @@ import ( | |||
| "github.com/spf13/viper" | |||
| ) | |||
|
|
|||
| var influxCmd = &cobra.Command{ | |||
There was a problem hiding this comment.
want to make this noted, the init and global state are 100% not needed. Only adds side effects and indirection in this case. Creating constructors allows the ability to provide DI for testing (see pkg_test.go)
kelwang
suggested changes
Nov 19, 2019
dearyhud
approved these changes
Nov 19, 2019
|
|
||
| // ComparePassword compares the user new password with existing. Note: is not implemented. | ||
| func (s *PasswordService) ComparePassword(ctx context.Context, name string, password string) error { | ||
| panic("not implemented") |
| @@ -72,6 +73,10 @@ func NewUserHandler(b *UserBackend) *UserHandler { | |||
| h.HandlerFunc("GET", usersLogPath, h.handleGetUserLog) | |||
| h.HandlerFunc("PATCH", usersIDPath, h.handlePatchUser) | |||
| h.HandlerFunc("DELETE", usersIDPath, h.handleDeleteUser) | |||
| // the POST doesn't need to be nested under users in this scheme | |||
| // seems worthwhile to make this a root resource in our HTTP API | |||
There was a problem hiding this comment.
I can agree w/ this, seems kind of odd to have this nested under the /users/:id path when id isn't used
jsteenb2
force-pushed
the
15897/pkger_authentication
branch
6 times, most recently
from
ee0278b
to
81c39d7
Compare
jsteenb2
force-pushed
the
15897/pkger_authentication
branch
from
81c39d7
to
091e6f8
Compare
one thing to note here is that new endpoint was created. there was no endpoint for setting an initial password that worked. The existin endpoint was a bit messy and coupled across multiple routes. Having multiple auth schemes proved incredibly taxing to write against.
jsteenb2
force-pushed
the
15897/pkger_authentication
branch
from
091e6f8
to
af8cc9d
Compare
|
tests failing in idpe here, will have follow up PR in idpe to touch that up. This is an expected failure: |
kelwang
approved these changes
Nov 20, 2019
bednar
added a commit
to influxdata/influxdb-client-csharp
that referenced
this pull request
Nov 22, 2019
bednar
added a commit
to influxdata/influxdb-client-java
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one thing to note here is that new endpoint was created. there was no
endpoint for setting an initial password that worked. The existing endpoint
was a bit messy and coupled across multiple routes. Having multiple auth
schemes proved incredibly taxing to write against.
update: this came up in discussion in another topic with @goller and from that conversation decided to fixup the password service interface here. To provide the user id instead of name as the first arg to each set/compare func in the PasswordService.
closes: #15977