feat(query): annotate logger with trace id and record query errors in trace log #16094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavincabbage
force-pushed
the
feat/query-trace-logging
branch
3 times, most recently
from
567e735
to
89694fc
Compare
gavincabbage
changed the title
ghost
requested review from
docmerlin
approved these changes
Dec 5, 2019
|
looks good once you fix what is causing tests to fail, imo. |
gavincabbage
force-pushed
the
feat/query-trace-logging
branch
4 times, most recently
from
7f5c7a7
to
02e87ac
Compare
gavincabbage
force-pushed
the
feat/query-trace-logging
branch
from
02e87ac
to
2e311cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR connects logged errors to their corresponding trace by annotating the logger with the request's trace ID. Additionally, errors bubbling up to the query handler are captured in the trace logs.
A small, unrelated README update is also included.
TraceInfomethod once its merged