Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): create cell view properties on dashboard creation #16112

Merged
merged 3 commits into from
Dec 4, 2019
Merged

feat(http): create cell view properties on dashboard creation #16112

merged 3 commits into from
Dec 4, 2019

Conversation

dearyhud
Copy link
Contributor

@dearyhud dearyhud commented Dec 4, 2019 •
edited
Loading

Closes #16112

Describe your proposed changes here.
An API user should be able to pass an optional param when creating a dashboard to create all nested data with one request.

POST /dashboards now optionally accepts a properties object nested within each cell.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)

@dearyhud dearyhud requested a review from a team December 4, 2019 17:10
@dearyhud dearyhud requested review from a team as code owners December 4, 2019 17:10
hoorayimhelping
hoorayimhelping reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nitpick about changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@dearyhud dearyhud merged commit ad96166 into master Dec 4, 2019
@dearyhud dearyhud deleted the 16053/dashboard-create-views branch December 4, 2019 19:47
@ebb-tide ebb-tide mentioned this pull request Dec 4, 2019
Open
drdelambre pushed a commit that referenced this pull request Dec 6, 2019
@dearyhud
feat(http): create cell view properties on dashboard creation (#16112)
e54621c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping left review comments

@ebb-tide ebb-tide ebb-tide left review comments

@kelwang kelwang kelwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dearyhud @hoorayimhelping @kelwang @ebb-tide