fix(ui): updated table threshold to set background colors for thresholds correctly #16172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
hoorayimhelping and
TCL735
and removed request for
a team
asalem1
changed the title
TCL735
reviewed
Dec 9, 2019
| } | ||
|
|
||
| private get isNaN(): boolean { | ||
| return isNaN(Number(this.props.data)) |
There was a problem hiding this comment.
Passing in null has now changed. Previously, using Number.parseFloat(null) would return NaN and ultimately the expression is NaN
Now, Number(null) returns 0, and ultimately the expression is not NaN
This looks like an improvement, because we do want to handle null values. Just wanted to make sure it was intentional.
TCL735
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15904
Problem
Setting table thresholds would not reflect changes to styling in the table ui
Solution
Added in check to colorization of the table thresholds to set the background colors correctly. Also updated a table method to correctly determine whether a value is a number or not