feat(endpoints): drop id prefix req endpoint secret key #16242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
feat/drop_id_prefix_req_endpoint_secret_key
branch
from
9183bb4
to
aaf2ccc
Compare
jsteenb2
changed the title
jsteenb2
force-pushed
the
feat/drop_id_prefix_req_endpoint_secret_key
branch
from
aaf2ccc
to
85edc98
Compare
jsteenb2
commented
Dec 17, 2019
| @@ -45,10 +45,10 @@ func (s Slack) Valid() error { | |||
| if err := s.Base.valid(); err != nil { | |||
| return err | |||
| } | |||
| if s.URL == "" && s.Token.Key == "" { | |||
| if s.URL == "" { | |||
There was a problem hiding this comment.
token is not required for a url, if URL is "" it shoudl be an eror for slack, token shoudn't matter
dearyhud
approved these changes
Dec 17, 2019
|
Are we using the id prefix anywhere for lookups? I just want to be sure that this isn't going to be a breaking change. |
|
@jademcgough we aren't atm. We save teh entire secrets bit into the store, and never actualy use the notification id to look for the secret, the entire key is provided. It can be |
jsteenb2
force-pushed
the
feat/drop_id_prefix_req_endpoint_secret_key
branch
from
85edc98
to
9b1526b
Compare
the original design made the secrets unable to be reused, a bit to opinionated to be useful eleswhere. This relaxes that requirement so that secrets can be referenced here.
jsteenb2
force-pushed
the
feat/drop_id_prefix_req_endpoint_secret_key
branch
from
9b1526b
to
10c243f
Compare
|
same failing data race test from tasks/backend |
imogenkinsman
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16240
Relaxes the rigid validation on endpoints to not require the id be prefixed.