Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): add dry run functionality for notification rules #16298

Merged
merged 1 commit into from
Dec 20, 2019
Merged

feat(pkger): add dry run functionality for notification rules #16298

merged 1 commit into from
Dec 20, 2019

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Dec 19, 2019 •
edited
Loading

@jsteenb2 jsteenb2 requested a review from a team December 19, 2019 22:12
@jsteenb2 jsteenb2 force-pushed the 4965p/pkger_parser_notif_rules branch from 40f5074 to 94a4259 Compare December 19, 2019 22:13
@jsteenb2 jsteenb2 force-pushed the 4965p/pkger_parser_notif_rules branch from 94a4259 to abf930e Compare December 20, 2019 00:17
@jsteenb2 jsteenb2 requested review from a team as code owners December 20, 2019 00:17
desa
desa approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@desa desa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jsteenb2 jsteenb2 merged commit 02aec6e into master Dec 20, 2019
@jsteenb2 jsteenb2 deleted the 4965p/pkger_parser_notif_rules branch December 20, 2019 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desa desa desa approved these changes

@dearyhud dearyhud dearyhud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsteenb2 @desa @dearyhud