fix(dataloader-buckets): default bucket selection should not be system bucket #16413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
changed the title
ebb-tide
force-pushed
the
deniz-default-bucket-selection
branch
from
b5ea66e
to
2112e3f
Compare
|
Looks good. |
TCL735
approved these changes
Jan 8, 2020
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
…m bucket (#16413) * fix(bucket-loading): Remove action duplication * fix(bucket-loading): Remove state loading before routing to data loaders * fix(bucket-loading): Limit available buckets to nonsystem buckets * fix(bucket-loading): Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15659
Data loader bucket selection was being made in several places, and though the dropdown buckets were filtered to remove system buckets, the default selection was choosing among all buckets. This PR filters system buckets before selecting default.