fix(ui): fixed table threshold bug and added option to make thresholds populate text or background #16430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s populate text or background
ghost
requested review from
121watts and
drdelambre
and removed request for
a team
asalem1
commented
Jan 7, 2020
| @@ -42,7 +42,7 @@ class TableCell extends PureComponent<Props> { | |||
| onClick={this.handleClick} | |||
| data-column-index={columnIndex} | |||
| data-row-index={rowIndex} | |||
| data-testID={`${data}-table-header`} | |||
| data-testid={`${data}-table-header`} | |||
There was a problem hiding this comment.
this was to fix a lingering linter error
| @@ -57,7 +57,7 @@ const ThresholdSetting: FunctionComponent<Props> = ({ | |||
| } else if (type === COLOR_TYPE_MAX) { | |||
| label = 'Maximum' | |||
| } else { | |||
| label = 'Value is <=' | |||
| label = 'Value is >=' | |||
There was a problem hiding this comment.
this change more accurately reflects the functionality of setting the thresholds
| @@ -119,3 +119,13 @@ export const DEFAULT_THRESHOLDS_LIST_COLORS = [ | |||
| value: 0, | |||
| }, | |||
| ] | |||
|
|
|||
| export const DEFAULT_THRESHOLDS_TABLE_COLORS = [ | |||
There was a problem hiding this comment.
updated the base table color based on discussions with @alexpaxton on what would look best
| @@ -88,10 +85,6 @@ export const generateThresholdsListHexs = ({ | |||
| lastValueNumber | |||
| ) | |||
|
|
|||
| if (cellType === 'table') { | |||
There was a problem hiding this comment.
removing these lines reverted the functionality to its original format, restoring it to what it was originally supposed to do
| @@ -131,6 +132,9 @@ export class TableOptions extends Component<Props, {}> { | |||
| onSetThresholds={onSetColors} | |||
| /> | |||
| </Grid.Column> | |||
| <Grid.Column> | |||
There was a problem hiding this comment.
adds a toggle to allow users to switch between threshold colors being set to the background or text color
|
lgtm |
drdelambre
approved these changes
Jan 7, 2020
alexpaxton
pushed a commit
that referenced
this pull request
Jan 9, 2020
…s populate text or background (#16430) fix(ui): fixed table threshold bug and added option to make thresholds populate text or background
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16309
Closes #16359
Problem
Table thresholds were automatically populating the background color rather than giving users an option.
Solution
Added option to toggle between views for table threshold so user can set background or text color. Changed the default table threshold base color to white after speaking with @alexpaxton about design and the need for a default base color.