feat(http): add configurable limit to points batch size on write endpoint #16469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeMac
commented
Jan 9, 2020
docmerlin
approved these changes
Jan 9, 2020
stuartcarnie
approved these changes
Jan 9, 2020
| @@ -72,7 +93,7 @@ const ( | |||
| ) | |||
|
|
|||
| // NewWriteHandler creates a new handler at /api/v2/write to receive line protocol. | |||
| func NewWriteHandler(log *zap.Logger, b *WriteBackend) *WriteHandler { | |||
| func NewWriteHandler(log *zap.Logger, b *WriteBackend, opts ...WriteHandlerOption) *WriteHandler { | |||
There was a problem hiding this comment.
❤️ the use of functional options
Comment on lines
+129
to
+136
| handleError = func(err error, code, message string) { | ||
| h.HandleHTTPError(ctx, &influxdb.Error{ | ||
| Code: code, | ||
| Op: "http/handleWrite", | ||
| Msg: message, | ||
| Err: err, | ||
| }, w) | ||
| } |
There was a problem hiding this comment.
💯 for refactoring this to a function
|
|
||
| code := influxdb.EInternal | ||
| if errors.Is(err, ErrMaxBatchSizeExceeded) { | ||
| code = influxdb.ETooLarge |
There was a problem hiding this comment.
Great to see the use of proper HTTP status codes 🎉
There was a problem hiding this comment.
You can tell what wikipedia page I spent some time on for this PR 😂
GeorgeMac
force-pushed
the
gm/write-points-batch-limit
branch
from
0686180
to
35d13eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13100
This enables support for a limit on the points batch size in bytes (after compression if compression is enabled).
To configure this the functional option
WithMaxBatchSizeByte(50 * 1024 * 1024)should be used when constructing ahttp.WriteHandler.