feat: resource log #16522
feat: resource log #16522
Conversation
gavincabbage
force-pushed
the
feat/kv-log
branch
from
5224902
to
c036ee2
Compare
gavincabbage
force-pushed
the
feat/kv-log
branch
2 times, most recently
from
f9214ac
to
266bce6
Compare
| @@ -8,6 +8,21 @@ import ( | |||
| icontext "github.com/influxdata/influxdb/context" | |||
| ) | |||
|
|
|||
| func TestGetAuthorizer(t *testing.T) { | |||
| func ErrInternalBucketServiceError(op string, err error) *Error { | ||
| return &Error{ | ||
| Code: EInternal, | ||
| Msg: fmt.Sprintf("unexpected error in buckets; Err: %v", err), | ||
| Op: op, | ||
| Err: err, | ||
| } | ||
| } |
There was a problem hiding this comment.
This is a great addition 🥇
| if err := s.putBucket(ctx, tx, b); err != nil { | ||
| v, err := json.Marshal(b) | ||
| if err != nil { | ||
| return influxdb.ErrInternalBucketServiceError(influxdb.OpCreateBucket, err) |
There was a problem hiding this comment.
I ❤️ the distinct errors
| type Change struct { | ||
| // Type of change. | ||
| Type ChangeType | ||
| // ResourceID of the changed resource. | ||
| ResourceID influxdb.ID | ||
| // ResourceType that was changed. | ||
| ResourceType influxdb.ResourceType | ||
| // OrganizationID of the organization owning the changed resource. | ||
| OrganizationID influxdb.ID | ||
| // UserID of the user changing the resource. | ||
| UserID influxdb.ID | ||
| // ResourceBody after the change. | ||
| ResourceBody []byte | ||
| // Time when the resource was changed. | ||
| Time time.Time | ||
| } |
There was a problem hiding this comment.
Wanted to state the design here, for my own clarification and thinking aloud. tl;dr is this approach is sound 👍
To know the specific changes made to a resource over time, we read its entire history and look at each prior ResourceBody to determine the deltas. Knowing that we will store the change history in InfluxDB, this approach is more efficient. Why? Prior values will be in the same column as the ResourceBody field and very likely stored in the same TSM block, so will be decompressed together. 💯
For posterity, the alternative would be to include the PreviousResourceBody as an additional value as a separate column. Whilst this approach may be better for a row-based data store, it will require separate reads for a columnar-based store like InfluxDB.
💯
gavincabbage
force-pushed
the
feat/kv-log
branch
from
266bce6
to
9697b60
Compare
This change introduces a resource audit logger to track changes to resources in the system. The operations on tasks, buckets and organizations are augmented to use this logger.
No implementation is currently provided.