feat(ui) More reasonable aggregate window intervals for selected query durations #16536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
force-pushed
the
deniz-clean-window-vars
branch
from
1d87c2d
to
f496f84
Compare
ebb-tide
changed the title
hoorayimhelping
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16354
If user selects
autofor aggregate window interval, in the Data Explorer or Cell Editor Overlay, the UI calculates an appropriate aggregate window interval for the query duration. The appropriate value is selected so that the UI doesn't request more points than can be displayed by the visulization. Before this PR we would divide the query duration by the number of pixels that can be displayed- which would result in aggregate windows which were not rounded like 0.83s for a query range of 5m. In this PR the aggregate window intervals are rounded to "more reasonable" values.Along the way, the aggregate window interval input was changed to a duration input, so that users can select any valid duration, and so that the duration is properly labeled and indicated to user.
...
Describe your proposed changes here.