Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd/influx): update password in cli #16537

Merged
merged 2 commits into from
Jan 15, 2020
Merged

feat(cmd/influx): update password in cli #16537

merged 2 commits into from
Jan 15, 2020

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Jan 14, 2020

Closes #16440

Add the feature, so cli can update user's password. manually tested.

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@kelwang kelwang requested a review from a team January 14, 2020 19:58
jsteenb2
jsteenb2 suggested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for this? This small body of change is a good candidate for the refactoring that is needed to make things testable 👍

@sanderson sanderson mentioned this pull request Jan 14, 2020
Closed
@kelwang kelwang requested a review from jsteenb2 January 15, 2020 16:50
jsteenb2
jsteenb2 approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@jsteenb2 jsteenb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reallllly good, super excited to see this part of the codebase become testable 😄 . Would be great if we can add some simple test cases to cover the env vars where they are possible.

cmd/influx/setup.go Show resolved Hide resolved
cmd/influx/user.go Outdated Show resolved Hide resolved
cmd/influx/user.go Outdated Show resolved Hide resolved
cmd/influx/user_test.go Show resolved Hide resolved
cmd/influx/user_test.go Outdated Show resolved Hide resolved
@kelwang kelwang force-pushed the cli_update_password branch 3 times, most recently from a29ccea to 1d87b87 Compare January 15, 2020 18:07
@kelwang
chore(cmd/influx): refactor user.go
cf5daee 
feat(cmd/influx): add user tests
fix(cmd/influx): make golint happier
@kelwang kelwang merged commit 540e785 into master Jan 15, 2020
@kelwang kelwang deleted the cli_update_password branch January 15, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imogenkinsman imogenkinsman imogenkinsman left review comments

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to update a user's password from the CLI
3 participants
@kelwang @imogenkinsman @jsteenb2