json.Unmarshal errors not catch in method client.Write

[akolosov]

No description provided.

[otoolep]

Makes sense to me.

On Feb 20, 2015, at 10:00 AM, Alexey Kolosov notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

#1662

Commit Summary

json.Unmarshal errors not catch in method client.Write
File Changes

M client/influxdb.go (3)
Patch Links:

https://github.com/influxdb/influxdb/pull/1662.patch
https://github.com/influxdb/influxdb/pull/1662.diff
—
Reply to this email directly or view it on GitHub.

[akolosov]

tests got 'unexpected end of JSON input' error, but you use Unmarshal instead Marshal... just make changes:

    //b := []byte{}
    //err := json.Unmarshal(b, &d)
    b, err := json.Marshal(d)
    if err != nil {
        return nil, err
    }

and tests done

[otoolep]

@corylanou -- can we merge this? Looks like the code was using the wrong function.

[corylanou]

We should open an issue to write a test around it, but other than that, looks good.

[d2g]

So #1680 is a test that covers this issue.

However also highlights the issue that the write() actually wraps the write{} in an array (not sure why) which isn't how it's expected at the server end.

[corylanou]

@d2g The write endpoint can take a single write, or multiple writes. This allows the end user to open an http endpoint and stream multiple writes without having to close the connection. This can cut down on the overhead of connecting/disconnecting, as that overhead is typically higher than the actual payload being sent.

[corylanou]

We should add test coverage for multiple writes at some point as well. Looking at the test coverage, that case it not covered. We also don't cover it in the documentation. I'll open up 2 issues prior to closing this issue as a reminder to update both test coverage and documentation.

[corylanou]

Fixed in #1868