Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): check engine closed before collecting index metrics #16656

Merged
merged 1 commit into from
Jan 23, 2020
Merged

fix(storage): check engine closed before collecting index metrics #16656

merged 1 commit into from
Jan 23, 2020

Conversation

jacobmarble
Copy link
Member

@jacobmarble jacobmarble commented Jan 23, 2020 •
edited
Loading

Helps influxdata/idpe#5720

It is possible to collect metrics after engine has closed. This checks for engine closed to prevent nil pointer exception.

sebito91
sebito91 approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@sebito91 sebito91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me!

@jacobmarble jacobmarble merged commit a56e022 into master Jan 23, 2020
@jacobmarble jacobmarble deleted the jgm-check-engine-closed branch January 23, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebito91 sebito91 sebito91 approved these changes

@tmgordeeva tmgordeeva tmgordeeva approved these changes

@benbjohnson benbjohnson Awaiting requested review from benbjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacobmarble @sebito91 @tmgordeeva