Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kv): fix patching panics #16733

Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix(kv): fix patching panics #16733

merged 1 commit into from
Feb 5, 2020

Conversation

kelwang
Copy link
Contributor

@kelwang kelwang commented Feb 5, 2020 •
edited

Closes #16293

When sending a patching request without status, notification rule will try to dereference the status, which results a panic. This ticket fixes the issue, adding a new test case for patching without status

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Well-formatted commit messages
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Documentation updated or issue created (provide link to issue/pr)
  • Signed CLA (if not already signed)

@kelwang kelwang requested a review from a team February 5, 2020 16:13
@kelwang kelwang merged commit e354fd0 into master Feb 5, 2020
@kelwang kelwang deleted the fix_rule_patching_panic branch February 5, 2020 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsteenb2 jsteenb2 jsteenb2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in notification rule when submitting a patch req to update name via UI
2 participants
@kelwang @jsteenb2