feat(cmd/influx): add secret cli #16786
Conversation
kelwang
force-pushed
the
feat_cli_secret
branch
from
82f6a5a
to
14a5804
Compare
kelwang
force-pushed
the
feat_cli_secret
branch
from
14a5804
to
d7b3228
Compare
kelwang
force-pushed
the
feat_cli_secret
branch
from
d7b3228
to
670d2b7
Compare
| cmd := b.newCmd("update", b.cmdUpdateRunEFn) | ||
| cmd.Short = "Update secret" | ||
| cmd.Flags().StringVarP(&b.key, "key", "k", "", "The secret key (required)") | ||
| cmd.MarkFlagRequired("key") | ||
| b.org.register(cmd, false) |
There was a problem hiding this comment.
You can pass a key, but how do you update the value of the secret?
There was a problem hiding this comment.
@sanderson This is done through a prompt similar to our password flow. I'm adding a card to provide it over the CLI as an arg in the same command.
| cmd := b.newCmd("find", b.cmdFindRunEFn) | ||
| cmd.Short = "Find secrets" | ||
| b.org.register(cmd, false) |
There was a problem hiding this comment.
This is an overall critique of "find"/"list" commands throughout the influx CLI. We are inconsistent. For some it's "list" and others it's "find". The term "find" indicates a searching action and I would expect ways to filter the results. This just lists all the secret keys.
My personal preference would be to make everything consistent and use either list or ls to align with standard Linux/UNIX command line tools.
@jademcgough
There was a problem hiding this comment.
@sanderson, this x1000! I've had the same feelings towards list|find. I would really love to see it become list if it does not allow for filtering. We do have filtering on some Find commands, either by name or what not. But these are still akin to list operations for me in most nix envs. I would love to see list and ls as an alias shorthand for calling it 👍
There was a problem hiding this comment.
@sanderson we're going to make these changes 👍. @influxdata/tools-team is on board 🤘
Closes #16475
Add the http secret service, cli, and tests