feat(sampledata): Route from buckets index to Data Explorer #17085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebb-tide
force-pushed
the
deniz-route-from-bucket-to-de
branch
from
b1e76e8
to
a55f597
Compare
ghost
requested review from
hoorayimhelping
approved these changes
Mar 4, 2020
| @@ -119,7 +128,7 @@ export default class BucketOverlayForm extends PureComponent<Props> { | |||
|
|
|||
| private get nameHelpText(): string { | |||
| if (this.props.disableRenaming) { | |||
| return 'To rename the bucket use the RENAME button. Bucket renaming is not allowed here.' | |||
| return 'To rename bucket use the RENAME button below' | |||
|
|
||
| props.onSetActiveTimeMachine('de') | ||
| const DataExplorer: FC<Props> = ({ |
There was a problem hiding this comment.
just want to call out that switching from a PureComponent to a FunctionComponent might have performance implications since a FC always renders, while a PureComponent sometimes doesn't re-render. I don't have enough context to provide anything more helpful than that :|
There was a problem hiding this comment.
thanks.. I'll test it a bit..
jacobmarble
pushed a commit
that referenced
this pull request
Mar 12, 2020
* feat(sampledata): Add routing to de from bucket name * feat(sampledata): Change rename edit bucket flow * feat(sampledata): Add onclick behavior to system buckets * feat(sampledata): Move rename button * feat(sampledata): Remove rename bucket button from create bucket overlay * feat(sampledata): Fix bucket tests * feat(sampledata): Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/influxdata/idpe/issues/6103