Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed threshold check bug that wouldn't allow threshold checks to be created where fields had spaces in them #17391

Merged
merged 6 commits into from
Mar 24, 2020

Conversation

asalem1
Copy link
Contributor

@asalem1 asalem1 commented Mar 23, 2020

Closes #17129

Problem

API could not handle spaces in field names

Solution

Updated the ast.MemberExpression Property to be a string rather than ast.Identifier so that we forced properties to bracket notation instead of dot notation (which was the cause of the error)

threshold-bug-fix

  • CHANGELOG.md updated with a link to the PR (not the Issue)

@asalem1 asalem1 requested review from a team and zoesteinkamp and removed request for a team March 23, 2020 21:04
@asalem1 asalem1 changed the title Fix/threshold check bug fix(ui): fixed threshold check bug that wouldn't allow threshold checks to be created where fields had spaces in them Mar 23, 2020
@drdelambre
Copy link
Contributor

does typing in a flux query with r.beans instead of r.["beans"] still work when initiated from the client side?

@asalem1
Copy link
Contributor Author

asalem1 commented Mar 23, 2020

does typing in a flux query with r.beans instead of r.["beans"] still work when initiated from the client side?

Yup.

Copy link
Contributor

@drdelambre drdelambre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go nuts

@asalem1 asalem1 merged commit 4f65cda into master Mar 24, 2020
@asalem1 asalem1 deleted the fix/threshold-check-bug branch March 24, 2020 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't add threshold check in Cloud 2 where field has a space in the name
2 participants